fix: Always trim strings to validate separately if required#193
Merged
patchzyy merged 1 commit intoSep 15, 2025
Conversation
patchzyy
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
Fix differences in name validation related to the use of
Trim()on the validated strings.How to Test:
Check the rename/naming popups for mod names, license names, and also those (including the "complex" popup) of the Mii editor for their behaviors with leading or trailing spaces with respect to the length of given names.
What Has Been Changed:
Drop
Trim()from theTextInputView– now the validation methods should themselves trim the text for length checks etc.Related Issue Link:
No related issue
Checklist before merging